Skip to content

Align dart_skills_lint with the example in dartlang - #69

Merged
reidbaker merged 1 commit into
flutter:mainfrom
reidbaker:r-align-dart-skills-lint-with-dartlang-project-templates
Apr 7, 2026
Merged

reidbaker merged 1 commit into
flutter:mainfrom
reidbaker:r-align-dart-skills-lint-with-dartlang-project-templates

Conversation

@reidbaker

Copy link
Copy Markdown
Contributor

Add licence file, contribution guidelines, authors, changelog and add the repo link in the pubspec.
https://github.com/dart-archive/dartlang_project_templates/tree/main

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing tests are passing.

@reidbaker
reidbaker requested a review from jwren April 7, 2026 19:06
@reidbaker
reidbaker merged commit cac85af into flutter:main Apr 7, 2026
7 checks passed

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request initializes the dart_skills_lint package by adding standard project files including AUTHORS, CHANGELOG, CONTRIBUTING, and LICENSE, and updating the pubspec.yaml with the repository URL. A formatting issue was identified in the AUTHORS file where an email address needs to be enclosed in angle brackets to match the file's instructions.

# Name/Organization <email address>

Google Inc.
Reid Baker reidbaker@google.com

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The email address should be enclosed in angle brackets to match the format specified in the file's instructions (line 4).

Reid Baker <reidbaker@google.com>

@reidbaker
reidbaker deleted the r-align-dart-skills-lint-with-dartlang-project-templates branch April 7, 2026 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants